Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8975" |
| assert(JSONValue(0u) == JSONValue(0)); | ||
| assert(JSONValue(0u) == JSONValue(0.0)); | ||
| assert(JSONValue(0) == JSONValue(0.0)); | ||
| assert(JSONValue(10).opEquals(JSONValue(10.0))); |
There was a problem hiding this comment.
If I use == here, the generator will convert it to:
writeln(JSONValue(10)); // JSONValue(10.0)
Hence I'm calling opEquals explicitly here.
There was a problem hiding this comment.
I recall such awkward situations coming up before. Maybe it's time to add some kind of // no-writeln syntax to https://github.com/dlang/dlang.org/blob/master/ddoc/source/assert_writeln_magic.d ?
There was a problem hiding this comment.
Or it could exempt documented unittests under opEquals
Co-authored-by: Dennis Korpel <dennis@sarc.nl>
Co-authored-by: Dennis Korpel <dennis@sarc.nl>
4 participants
No description provided.